fix(deps): exclude RELATES_TO edges from cycle detection#65
Merged
Conversation
RELATES_TO dependencies are purely informational and cannot create blocking deadlocks. The DFS cycle detection was incorrectly traversing RELATES_TO edges, causing false positive cycle rejections — e.g., creating B RELATES_TO A when A BLOCKS B existed would be rejected. Three changes: - DFS filter: `!= IS_BLOCKED_BY` → `== BLOCKS` (excludes RELATES_TO) - insertDependencyInTransaction: skip cycle check for RELATES_TO - createBatch: skip cycle check for RELATES_TO Adds 5 TDD tests covering the fix and regression guards. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dep.type != IS_BLOCKED_BYtraversed RELATES_TO edges as if they were blocking; changed todep.type == BLOCKStype != RELATES_TOchecks at bothcreate()andcreateBatch()call sites to skip cycle detection entirely for informational depsTest Results
Review
/simplifypass: code is clean, no changes neededMCP Items
0afc3836— Unify DependencyRepository sync/async API and fix cycle detection🤖 Generated with Claude Code